#105 #136
Merged
#105 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Feb 3, 2022
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Feb 4, 2022
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Feb 4, 2022
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Feb 4, 2022
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Feb 4, 2022
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
…gPlugin.scala Co-authored-by: Arman Bilge <armanbilge@gmail.com>
…gPlugin.scala Co-authored-by: Arman Bilge <armanbilge@gmail.com>
armanbilge
reviewed
Feb 4, 2022
Comment on lines
+88
to
+95
| V(version) match { | ||
| case None => | ||
| sys.error(s"version must be semver format: $version") | ||
| case Some(value) => | ||
| if (!(value.isSameSeries(baseV) || value >= baseV)) | ||
| sys.error( | ||
| s"Your current version $version cannot be less than tlBaseVersion $baseV") | ||
| } |
There was a problem hiding this comment.
I totally missed this: actually, we need to move this check outside of the current { }. Otherwise it's missing the current tags which are read here:
|
Thanks for working on this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail if tag is older than base version #105