-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail if tag is older than base version #105
Comments
I just commented somewhere else, but I'd also like to be scolded if the base version is older than the latest tag on the branch. I've seen MiMa failures at publish time because the new tag is the first time MiMa runs on new versions. |
Yes, I replied there too 😉 that is already supported: if the base version is older than the latest tag, it will fail to start sbt. |
@osleonard will work on this :) |
@osleonard btw let me know if you need any more pointers, since this is a bug I'd really love to get this into the next release :) Here's where do the check in the opposite direction, if the baseVersion is older than the latest tag: sbt-typelevel/versioning/src/main/scala/org/typelevel/sbt/TypelevelVersioningPlugin.scala Lines 76 to 83 in 58ad2e7
|
- add in comment
As long as you have binary-breaking changes on a branch, then tagging a non-breaking version number will fail the bincompat checks.
However, currently in sbt-typelevel the series/0.4 branch and main (base version 0.5) are actually binary-compatible, but semantically incompatible. So accidentally tagging 0.4.x on main would succeed in publishing, which is not what we want.
The text was updated successfully, but these errors were encountered: