[BUGFIX] ObjectMetadata item server validation

[prastoin]

Introduction

This PR contains several SNAPSHOT files explaining big +

While refactoring the Object Model settings page in #10653, encountered a critical issue when submitting either one or both names with "" empty string hard corrupting a workspace.

This motivate this PR reviewing server side validation

I feel like we could share zod schema between front and back

Refactored server validation

What to expect from Names:

• Plural and singular have to be different ( case insensitive and trimmed check )
• Contains only a-z A-Z and 0-9
• Follows camelCase
• Is not empty => Is not too short ( 1 )
• Is not too long ( 63 )
• Is case insensitive( fooBar and fOoBar now rejected )

What to expect from Labels:

• Plural and singular have to be different ( case insensitive and trimmed check )
• Is not empty => Is not too short ( 1 )
• Is not too long ( 63 )
• Is case insensitive ( fooBar and fOoBar now rejected )

close #10694

Creation integrations tests

Created new integrations tests, following EachTesting pattern and uses snapshot to assert errors message. These tests cover several failing use cases and started to implement ones for the happy path but object metadata item deletion is currently broken unless I'm mistaken @Weiko is on it

Notes

• As we've added new validation rules towards names and labels we should scan db in order to standardize existing values using either a migration command or manual check
• Will review in an other PR the update path, adding integrations tests and so on

[prastoin]

Note: Will pass on update in an other PR

[Weiko]

Nice PR!
FYI I had the idea of using class-validator (which is more standard with nestjs backend) with custom validation decorators over our input classes but I think with your implementation it's a bit less important, will see how it scales 👍

[prastoin]

@greptileai trigger

[greptile-apps]

PR Summary

(updates since last review)

Based on the provided information, I'll summarize the key changes in this PR focusing on the most recent updates without repeating previous points:

Enhanced server-side validation for ObjectMetadata with new utility functions:

• Added validateMetadataNameIsCamelCaseOrThrow to enforce camelCase naming convention
• Implemented validateMetadataNameIsNotTooShort/LongOrThrow to enforce length constraints (1-63 chars)
• Created validateMetadataNameContainsWhitelistedCharacters to restrict to alphanumeric characters
• Introduced validateLowerCasedAndTrimmedStringsAreDifferentOrThrow to ensure unique singular/plural names

The changes consolidate error handling by:

• Replacing multiple specific exceptions with unified InvalidMetadataNameException
• Improving error messages with detailed validation failure reasons
• Adding case-insensitive comparison for name uniqueness checks

These updates provide a more robust validation system while maintaining clean code organization and improved error handling.

_{24 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile}

[Weiko]

Great job @prastoin!! LGTM