Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Should update dependencies cache when local package as dependencies mutates #544

Closed
prastoin opened this issue Mar 7, 2025 · 2 comments
Assignees

Comments

@prastoin
Copy link

prastoin commented Mar 7, 2025

Introduction

When updating several packages within a same PR, a introducing a mutation, this might bring cache invalidation as in twentyhq/twenty#10699

Twenty-shared is now a dependency, which means it will be cached along node-modules, when updating and rebuilding it it does not change the lockfile which result in not updating the cache

Solutions:

Semver

  • Follow not a * version but a specific ^ version, this should update lockfile this means we need to upgrade the sub dep version each time ...

To be thinked further !

Changed files

Look in latest commit if a local package as been modified, if yes than invalidate cache

@prastoin
Copy link
Author

prastoin commented Mar 9, 2025

I think the initial issue is related to nx not detecting a diff in build due to import path update that resulted in the same transpilation 🤔
at least something very specific cannot reproduce the error again either
Closing this from now

@prastoin prastoin closed this as completed Mar 9, 2025
@prastoin
Copy link
Author

prastoin commented Mar 9, 2025

Update

I'm just a fool and spent 2 hours trying to debug something that wasn't a caching issue but a human man
Also useless to do not cache node_modules local packages as they only contain symlink to corresponding packages folders

I'm a fool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Planned
Development

No branches or pull requests

1 participant