Linkstatic shell tests #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `provides` field to haskell_library and haskell_binary to tell users about our custom providers (and possibly throw better error messages). As a related change, the `load` targets for `providers.bzl` are made absolute to work around bazelbuild/bazel#3115
Like sh_test, but takes a (multiline) string to specify the shell script inline instead of a different file.
Adds two shell tests that use readelf to check that the `linkstatic` option has the expected behavior: - When it’s set to True it only produces static libraries (.a) - When it’s set to False it produces both .a and .so - .a is a static ELF (no interpreter) and .so is a dynamic ELF (interpreter appears in the ELF header INTERP field)
1a53ecf to
bc1ce90
Compare
|
Meh, I can just revert that part of the change, it’s not crucial. |
Similar to bazelbuild/skydoc#59 it also doesn’t support `provides`. Since `provides` is just nice-to-have, we drop it for now.
mboes
reviewed
Nov 22, 2018
| @@ -8,7 +8,7 @@ load( | |||
| "target_unique_name", | |||
| ) | |||
| load( | |||
| ":private/providers.bzl", | |||
| "@io_tweag_rules_haskell//haskell:private/providers.bzl", | |||
There was a problem hiding this comment.
Sadly yes, to navigate around bazelbuild/bazel#3115
There was a problem hiding this comment.
Could you add a note inline about this at the top of providers.bzl about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon #487 this adds two tests to check whether the generated ELF binaries are actually linked as we expect them to be.
Adds a primitive to read a Skylark string into a single-file target (candidate for some bazel-focused library, akin to
build-supportin nixpkgs?) and ashell_inline_testwrapper aroundshell_testto make small test scripts less cluttered to write and read.