Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

New 'doc' arguments throw an error. #59

Closed
siddharthab opened this issue Sep 20, 2017 · 0 comments
Closed

New 'doc' arguments throw an error. #59

siddharthab opened this issue Sep 20, 2017 · 0 comments

Comments

@siddharthab
Copy link

siddharthab commented Sep 20, 2017 •
edited
Loading

I am getting these errors when trying to generate skydoc rules at skydoc release 0.1.3. The rules themselves work fine with bazel 0.5.3 and up.

TypeError: string() got an unexpected keyword argument 'doc'
TypeError: label_list() got an unexpected keyword argument 'doc'

Should I expect these errors to go away in a release in near future, or should I remove all doc arguments from my attributes?

Thank you.
@hsyed hsyed mentioned this issue Jan 2, 2018
Closed
mboes added a commit to tweag/rules_haskell that referenced this issue Jan 6, 2018
@mboes
Drop docstrings for attributes.
d4442a8 
Due to bazelbuild/skydoc#59, Skydoc chokes
on these. They're otherwise unused by any tool. And it's proven hard
to keep them in sync with text documentation. So favour text
documentation for now, until Skydoc comes of age.
mboes added a commit to tweag/rules_haskell that referenced this issue Jan 6, 2018
@mboes
Drop docstrings for attributes.
be29520 
Due to bazelbuild/skydoc#59, Skydoc chokes
on these. They're otherwise unused by any tool. And it's proven hard
to keep them in sync with text documentation. So favour text
documentation for now, until Skydoc comes of age.
mboes added a commit to tweag/rules_haskell that referenced this issue Jan 6, 2018
@mboes
Drop docstrings for attributes.
e9d3333 
Due to bazelbuild/skydoc#59, Skydoc chokes
on these. They're otherwise unused by any tool. And it's proven hard
to keep them in sync with text documentation. So favour text
documentation for now, until Skydoc comes of age.
mboes added a commit to tweag/rules_haskell that referenced this issue Jan 6, 2018
@mboes
Drop docstrings for attributes.
b3a0197 
Due to bazelbuild/skydoc#59, Skydoc chokes
on these. They're otherwise unused by any tool. And it's proven hard
to keep them in sync with text documentation. So favour text
documentation for now, until Skydoc comes of age.
mboes added a commit to tweag/rules_haskell that referenced this issue Jan 6, 2018
@mboes
Drop docstrings for attributes.
68d03ea 
Due to bazelbuild/skydoc#59, Skydoc chokes
on these. They're otherwise unused by any tool. And it's proven hard
to keep them in sync with text documentation. So favour text
documentation for now, until Skydoc comes of age.
mboes added a commit to tweag/rules_haskell that referenced this issue Jan 7, 2018
@mboes
Drop docstrings for attributes.
20d3b19 
Due to bazelbuild/skydoc#59, Skydoc chokes
on these. They're otherwise unused by any tool. And it's proven hard
to keep them in sync with text documentation. So favour text
documentation for now, until Skydoc comes of age.
@mboes mboes mentioned this issue Feb 11, 2018
Merged
laurentlb pushed a commit that referenced this issue Feb 22, 2018
@mboes @laurentlb
Support attribute documentation via doc argument. (#85)
4cc5148 
Fixes #59.
@Profpatsch Profpatsch mentioned this issue Nov 22, 2018
Merged
Profpatsch added a commit to tweag/rules_haskell that referenced this issue Nov 22, 2018
@Profpatsch
remove provides from rule(), because skydoc barfs
100073a 
Similar to bazelbuild/skydoc#59 it also
doesn’t support `provides`.
Since `provides` is just nice-to-have, we drop it for now.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siddharthab