Import stackage as dev-dependency #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise these package imports impact downstream users, which may face issues due to packages missing in their selected Stackage snapshot.
aherrmann
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
Sep 27, 2023
So that rules_haskell no longer impacts downstream Stackage snapshot imports. tweag/rules_haskell#1968
All dependencies in rules_haskell_tests are "for tests".
1 task
aherrmann
added a commit
to tweag/gazelle_cabal
that referenced
this pull request
Oct 2, 2023
So that rules_haskell no longer impacts downstream Stackage snapshot imports. tweag/rules_haskell#1968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the stack_snapshot imports within rules_haskell itself as dev_dependencies.
Otherwise downstream users of rules_haskell will have the same packages imported into their Stackage snapshot as used by rules_haskell for testing purposes. This can cause problems if downstream users want to use a different Stackage snapshot that may not include one of the dependencies imported by rules_haskell.
Note, due to a reference to
@stackagefrom within thestack_snapshotimplementation we still need to import the repository@stackagein all cases. This is done by using separate references to the extension, one marked as dev-dependency and the other not. However, they both refer to the same underlying instance of the module extension.