Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple GHC versions with bzlmod. #68

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

aherrmann
Copy link
Member

@aherrmann aherrmann commented Sep 27, 2023

This completes #66.
Depends on #60.

Depends on tweag/rules_haskell#1968.
Previously, rules_haskell would configure a Stackage snapshot and import packages declared as regular dependencies. This meant that these configurations were visible to downstream users and could conflict with downstream snapshot configuration, e.g. missing packages.

This runs CI on the examples tests with bzlmod enabled for multiple GHC versions. This requires configuring the GHC version. Since the GHC version number needs to be declared in the MODULE.bazel file to import the Nix provided GHC toolchain, we have to find a way to change this setting in the MODULE.bazel file for different CI matrix branches.

MODULE.bazel does not support load or any other similar way to change such configuration. Instead, the CI script simply replacese the GHC version number (factored out into a dedicated variable) in MODULE.bazel.

  • Select the local Stackage snapshot
  • Update rules_haskell to include rules_haskell#1968
  • Configure the GHC version in bzlmod mode
  • Test bzlmod with multiple GHC versions

@aherrmann aherrmann marked this pull request as ready for review September 29, 2023 14:15
@aherrmann aherrmann requested a review from avdv as a code owner September 29, 2023 14:15
Base automatically changed from bzlmod to main September 29, 2023 14:23
@dpulls
Copy link

dpulls bot commented Sep 29, 2023

🎉 All dependencies have been resolved !

@aherrmann
Copy link
Member Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

rebase

✅ Branch has been successfully rebased

@aherrmann aherrmann force-pushed the bzlmod-ghc-versions branch from d237fe4 to 65b47f5 Compare October 2, 2023 07:17
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot merged commit 07e2ac7 into main Oct 16, 2023
@mergify mergify bot deleted the bzlmod-ghc-versions branch October 16, 2023 08:30
@mergify mergify bot removed the merge-queue label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants