Update AWS4RequestSigner.cs Sort Comparer #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently made a change to the sort comparer for the query params to use the
StringComparer.OrdinalIgnoreCase
(see PR #29) instead of the defaultOrdinal
is required to satisfy AWS's requirements butOrdinalIgnoreCase
was used instead to follow AWS's internal signer.We recently encountered a similar issue as before and discovered that the using "Ignore Case" was not producing the expected signature so we switched to
Ordinal
and that resolved the issue. The docs also mention briefly that casing is NOT ignore so I suspect that the AWS internal signer is incorrect.