Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS4RequestSigner.cs Sort Comparer #31

Merged
merged 2 commits into from
May 19, 2021

Conversation

branch-slalom
Copy link
Contributor

@branch-slalom branch-slalom commented May 3, 2021

I recently made a change to the sort comparer for the query params to use the StringComparer.OrdinalIgnoreCase (see PR #29) instead of the default

Ordinal is required to satisfy AWS's requirements but OrdinalIgnoreCase was used instead to follow AWS's internal signer.

We recently encountered a similar issue as before and discovered that the using "Ignore Case" was not producing the expected signature so we switched to Ordinal and that resolved the issue. The docs also mention briefly that casing is NOT ignore so I suspect that the AWS internal signer is incorrect.

Sort the parameter names by character code point in ascending order. Parameters with duplicate names should be sorted by value. For example, a parameter name that begins with the uppercase letter F precedes a parameter name that begins with a lowercase letter b.

@branch-slalom
Copy link
Contributor Author

@tsibelman Can you have a look at this?

@tsibelman tsibelman merged commit 464a21c into tsibelman:master May 19, 2021
@tsibelman
Copy link
Owner

Thanks I published a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants