Update AWS4RequestSigner.cs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `StringComparer.Ordinal` when sorting query params
|
Please update version number as well. |
Bump nuget version
|
@tsibelman Updated the version number in the csproj. Thanks for the quick response! |
Change Comparer to use `OrdinalIgnoreCase` (to align with AWS Internal signer)
|
@tsibelman Have you had a chance to look at the changes? Was hoping to have this merged sooner rather than later |
|
Hi published the nuget |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
StringComparer.OrdinalIgnoreCasewhen sorting query paramsTo add some more detail, query params need to be sorted by their "character code point".
https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html
The internal AWS4Signer also uses the
OrdinalIgnoreCasehttps://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/Amazon.Runtime/Internal/Auth/AWS4Signer.cs#L843-L850