Add support for double to varchar coercion in hive tables #18832
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.hive.coercions; | ||
|
|
||
| import io.airlift.slice.Slice; | ||
| import io.airlift.slice.Slices; | ||
| import io.trino.spi.TrinoException; | ||
| import io.trino.spi.block.Block; | ||
| import io.trino.spi.block.BlockBuilder; | ||
| import io.trino.spi.type.DoubleType; | ||
| import io.trino.spi.type.VarcharType; | ||
|
|
||
| import static io.airlift.slice.SliceUtf8.countCodePoints; | ||
| import static io.trino.spi.StandardErrorCode.INVALID_ARGUMENTS; | ||
| import static io.trino.spi.type.DoubleType.DOUBLE; | ||
| import static io.trino.spi.type.Varchars.truncateToLength; | ||
| import static java.lang.String.format; | ||
|
|
||
| public class DoubleToVarcharCoercer | ||
| extends TypeCoercer<DoubleType, VarcharType> | ||
| { | ||
| public DoubleToVarcharCoercer(VarcharType toType) | ||
| { | ||
| super(DOUBLE, toType); | ||
| } | ||
|
|
||
| @Override | ||
| protected void applyCoercedValue(BlockBuilder blockBuilder, Block block, int position) | ||
| { | ||
| double doubleValue = DOUBLE.getDouble(block, position); | ||
| Slice converted = Slices.utf8Slice(Double.toString(doubleValue)); | ||
| if (!toType.isUnbounded() && countCodePoints(converted) > toType.getBoundedLength()) { | ||
| throw new TrinoException(INVALID_ARGUMENTS, format("Varchar representation of %s exceeds %s bounds", doubleValue, toType)); | ||
| } | ||
| toType.writeSlice(blockBuilder, truncateToLength(converted, toType)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.plugin.hive.coercions; | ||
|
|
||
| import io.airlift.slice.Slices; | ||
| import io.trino.spi.TrinoException; | ||
| import io.trino.spi.block.Block; | ||
| import io.trino.spi.type.Type; | ||
| import org.testng.annotations.DataProvider; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| import static io.trino.plugin.hive.HiveTimestampPrecision.DEFAULT_PRECISION; | ||
| import static io.trino.plugin.hive.HiveType.toHiveType; | ||
| import static io.trino.plugin.hive.coercions.CoercionUtils.createCoercer; | ||
| import static io.trino.spi.predicate.Utils.blockToNativeValue; | ||
| import static io.trino.spi.predicate.Utils.nativeValueToBlock; | ||
| import static io.trino.spi.type.DoubleType.DOUBLE; | ||
| import static io.trino.spi.type.VarcharType.createUnboundedVarcharType; | ||
| import static io.trino.spi.type.VarcharType.createVarcharType; | ||
| import static io.trino.type.InternalTypeManager.TESTING_TYPE_MANAGER; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| public class TestDoubleToVarcharCoercions | ||
| { | ||
| @Test(dataProvider = "doubleValues") | ||
| public void testNaNToVarcharCoercions(Double doubleValue) | ||
| { | ||
| assertCoercions(DOUBLE, doubleValue, createUnboundedVarcharType(), Slices.utf8Slice(doubleValue.toString())); | ||
| } | ||
|
|
||
| @Test(dataProvider = "doubleValues") | ||
| public void testDoubleSmallerVarcharCoercions(Double doubleValue) | ||
| { | ||
| assertThatThrownBy(() -> assertCoercions(DOUBLE, doubleValue, createVarcharType(1), doubleValue.toString())) | ||
| .isInstanceOf(TrinoException.class) | ||
| .hasMessageContaining("Varchar representation of %s exceeds varchar(1) bounds", doubleValue); | ||
| } | ||
|
|
||
| @DataProvider | ||
| public Object[][] doubleValues() | ||
| { | ||
| return new Object[][] { | ||
| {Double.MAX_VALUE}, | ||
| {Double.MAX_VALUE}, | ||
| {Double.parseDouble("123456789.12345678")}, | ||
| {Double.NaN}, | ||
| }; | ||
| } | ||
|
|
||
| public static void assertCoercions(Type fromType, Object valueToBeCoerced, Type toType, Object expectedValue) | ||
| { | ||
| Block coercedValue = createCoercer(TESTING_TYPE_MANAGER, toHiveType(fromType), toHiveType(toType), DEFAULT_PRECISION).orElseThrow() | ||
| .apply(nativeValueToBlock(fromType, valueToBeCoerced)); | ||
| assertThat(blockToNativeValue(toType, coercedValue)) | ||
| .isEqualTo(expectedValue); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a bug that we should track?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is how ORC file behaves, I'm not sure if we need to track them in ORC project