Add support for double to varchar coercion in hive tables #18832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90d2186 to
5669331
Compare
5669331 to
14abcb9
Compare
atanasenko
reviewed
Sep 1, 2023
| @@ -321,6 +333,8 @@ else if (getHiveVersionMajor() == 3 && isFormat.test("orc")) { | |||
| 0.5, | |||
| -1.5)) | |||
| .put("double_to_float", ImmutableList.of(0.5, -1.5)) | |||
| .put("double_to_string", Arrays.asList("12345.12345", coercedNaN)) | |||
There was a problem hiding this comment.
coercedNaN can be null - so ImmutableList might fails.
atanasenko
reviewed
Sep 1, 2023
| @@ -61,6 +61,8 @@ private static HiveTableDefinition.HiveTableDefinitionBuilder tableDefinitionBui | |||
| bigint_to_varchar BIGINT, | |||
| float_to_double FLOAT, | |||
| double_to_float DOUBLE, | |||
| double_to_string DOUBLE, | |||
| double_to_bounded_varchar DOUBLE, | |||
There was a problem hiding this comment.
What about a test for out of bounds?
krvikash
approved these changes
Sep 4, 2023
vlad-lyutenko
approved these changes
Sep 4, 2023
kokosing
reviewed
Sep 4, 2023
| @@ -241,6 +248,11 @@ else if (getHiveVersionMajor() == 3 && isFormat.test("orc")) { | |||
| hiveValueForCaseChangeField = "\"LOWER2UPPERCASE\":2"; | |||
| } | |||
|
|
|||
| // For ORC when we coerce NaN to String, it returns coerced value as `null` | |||
There was a problem hiding this comment.
is this a bug that we should track?
There was a problem hiding this comment.
It is how ORC file behaves, I'm not sure if we need to track them in ORC project
14abcb9 to
2e89056
Compare
|
@atanasenko AC |
atanasenko
approved these changes
Sep 5, 2023
kokosing
approved these changes
Sep 5, 2023
|
Overridden by #18930 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows coerce a double type to varchar in hive tables.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: