Update SQL Server JDBC driver to 10.2.0

[mosabua]

Description

Update the JDBC driver to the new major release version. Using the Java 11 version. A Java 17 one is also available if desired. This enables a simpler upgrade to the Java 17 version in the future when we update Trino to use 17.

See release notes for the new version for details. https://docs.microsoft.com/en-us/sql/connect/jdbc/release-notes-for-the-jdbc-driver?view=sql-server-ver15#94

General information

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces (be specific)?

SQL Server connector only

How would you describe this change to a non-technical end user or system administrator?

Using the new JDBC driver enables us to switch to the Java 17 version soon. The old version does not have Java 17 support.

Related issues and pull requests

• Potentially enables update to Java 17 since this is the first version of the JDBC driver with Java 17 support, see Update to Java 17 #9876
• Related issue in upstream Java 17 support out of preview? microsoft/mssql-jdbc#1732

Documentation

( ) No documentation is needed.
(✅ ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(✅ ) Release notes entries required with the following suggested text:

## SQL Server connector

* Update JDBC driver to 10.2.0. Upgrade requires catalog configuration changes since the new version automatically enables encryption.  ({issue}`10898`)

Release notes should link to the updated section in the docs about the Connection security.

[mosabua]

Waiting for results from CI run to see how it goes..

[mosabua]

Giving this a WIP for now to wait and see what CI results are

[mosabua]

sigh ... looks like there are test failures with this driver. We will have to investigate some more..

[ebyhr]

Specifying encrypt=false would resolve the test failure.

[hashhar]

The driver has breaking changes for TLS handling. encryption is enabled by default, and certificate verification is also enabled by default.

We should point users to the JDBC driver release notes to check them and adjust accordingly.
Maybe something like:

* Update JDBC driver to 10.2.0. There are some breaking changes in the driver - see https://docs.microsoft.com/en-us/sql/connect/jdbc/release-notes-for-the-jdbc-driver?view=sql-server-ver15#94 for details. ({issue}`10898`)

[mosabua]

Specifying encrypt=false would resolve the test failure.

Do you know where? I have to dig into this still. I assume in the connection URL in the test or so .. right?

[ebyhr]

@mosabua You can add withUrlParam("encrypt", "false"); to TestingSqlServer L114.

[mosabua]

Should be good for review now @ebyhr and @hashhar

Product tests are still failing

[hashhar]

URL needs to be changed in

trino/testing/trino-product-tests/src/main/resources/tempto-configuration.yaml

Line 137 in a125581

jdbc_url: jdbc:sqlserver://sqlserver

too.

[mosabua]

Thanks for letting me know @hashhar . I haven't looked yet .. but have now fix this as well. Fingers crossed we get a passing build including tests.

[mosabua]

From what I can tell the CI failures are not related to sqlserver anymore. Do I need to rebase or what can I do to get a green build overall @hashhar ? Or even a merge? Anything else I can do?

[hashhar]

CI hit #11203

[mosabua]

Wow.. soo good. Thanks for all the help and the merge @hashhar and @ebyhr !