-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pull request template #10816
Add pull request template #10816
Conversation
f0b8adc
to
26a50c8
Compare
d049a32
to
007ea0c
Compare
501e7e8
to
0b32fb3
Compare
Instead of introducing a bloated and controversial PR template, can we have a lean one, that we agree about? Iterate. |
Here is a live PR that used the template already manually - #10898 |
i read there
This is a good example why we shouldn't ask contributors for release notes. in that PR, a contributor didn't now the release notes need to present the change from user perspective. |
Everyone please keep in mind that this is all just a template .. there is no enforcement to use it. |
8be2d7c
to
57f6cb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough to try out. If we don't like it, we can always remove it.
@dain and myself found some issues with the checkbox syntax interfering with GHA .. should be all fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This is a good start! Once we see how people end up using it in practice, we can adjust it.
As agreed with @martint here is a first draft. This is aimed to improve release process and contributions to be scoped better, and to make the relevant information more easily available.
Open to any feedback for improvements/adjustments.