Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #10816

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add pull request template #10816

merged 1 commit into from
Feb 4, 2022

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Jan 26, 2022

As agreed with @martint here is a first draft. This is aimed to improve release process and contributions to be scoped better, and to make the relevant information more easily available.

Open to any feedback for improvements/adjustments.

@cla-bot cla-bot bot added the cla-signed label Jan 26, 2022
@mosabua mosabua requested a review from martint January 26, 2022 21:47
@mosabua mosabua force-pushed the pr-template branch 2 times, most recently from f0b8adc to 26a50c8 Compare January 26, 2022 21:51
@mosabua mosabua force-pushed the pr-template branch 2 times, most recently from d049a32 to 007ea0c Compare January 27, 2022 00:28
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@mosabua mosabua force-pushed the pr-template branch 4 times, most recently from 501e7e8 to 0b32fb3 Compare January 31, 2022 20:36
@findepi
Copy link
Member

findepi commented Feb 1, 2022

Instead of introducing a bloated and controversial PR template, can we have a lean one, that we agree about? Iterate.

@mosabua
Copy link
Member Author

mosabua commented Feb 1, 2022

Here is a live PR that used the template already manually - #10898

@findepi
Copy link
Member

findepi commented Feb 2, 2022

Here is a live PR that used the template already manually - #10898

i read there

  • Update JDBC driver to 10.2.0 ({issue}10898)

This is a good example why we shouldn't ask contributors for release notes.

in that PR, a contributor didn't now the release notes need to present the change from user perspective.
Version upgrade of an underlying library hardly translates to user visible impact, unless user does their job and checks why we could have done the upgrade.

@mosabua
Copy link
Member Author

mosabua commented Feb 2, 2022

Everyone please keep in mind that this is all just a template .. there is no enforcement to use it.

@mosabua mosabua force-pushed the pr-template branch 5 times, most recently from 8be2d7c to 57f6cb5 Compare February 3, 2022 02:25
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough to try out. If we don't like it, we can always remove it.

@mosabua
Copy link
Member Author

mosabua commented Feb 3, 2022

@dain and myself found some issues with the checkbox syntax interfering with GHA .. should be all fixed now

Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This is a good start! Once we see how people end up using it in practice, we can adjust it.

@dain dain merged commit fb59c10 into trinodb:master Feb 4, 2022
@github-actions github-actions bot added this to the 371 milestone Feb 4, 2022
@mosabua mosabua deleted the pr-template branch February 4, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants