Import order everywhere #15264
Merged
Import order everywhere #15264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Lemonexe
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Honestly TL;DR 😂 I did not review it whole, but a sample of the diff looks fine.
I also ran eslint fix locally from develop with the rule on, cherry picked your 2nd commit and git diff MY_BRANCH..import-order-everywhere produces no diff, so LGTM 🤷 ✔️
Thank you so much for getting the courage to do it! I admit I sometimes can't resist the temptation to tweak import order manually when working on new files, but from now on I won't have to because it will be deterministic 🚀
2d8d219 to
644130b
Compare
644130b to
3b94398
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14031