You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I really like when imports are sorted since you know what are you importing from libraries, files etc. This makes even more sense to our repo because we would be able to differentiate imports from external libraries, @trezor packages, @suite-common packages, @suite-native packages and files. To what and how many groups we will divide imports is for sure open for a discussion.
There are multiple tools for import sorting that work nicely out of the box (for example this one).
// 🔴 not that cleanimport{decode,verify}from'jws';import{jwsasconfigJwsLocal}from'../files/config.v1';import{ACTION_PREFIX,messageSystemActions}from'./messageSystemActions';import{getJWSPublicKey,isCodesignBuild,isNative}from'@trezor/env-utils';import{memoize,memoizeWithArgs}from'proxy-memoize';// 🟢 nice and cleanimport{decode,verify}from'jws';import{memoize,memoizeWithArgs}from'proxy-memoize';import{getJWSPublicKey,isCodesignBuild,isNative}from'@trezor/env-utils';import{jwsasconfigJwsLocal}from'../files/config.v1';import{ACTION_PREFIX,messageSystemActions}from'./messageSystemActions';
The text was updated successfully, but these errors were encountered:
I really like when imports are sorted since you know what are you importing from libraries, files etc. This makes even more sense to our repo because we would be able to differentiate imports from external libraries,
@trezor
packages,@suite-common
packages,@suite-native
packages and files. To what and how many groups we will divide imports is for sure open for a discussion.There are multiple tools for import sorting that work nicely out of the box (for example this one).
The text was updated successfully, but these errors were encountered: