chore(suite): unify staking files #15108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dev-pvl please resovle conflicts |
1d7add7 to
1e45c7e
Compare
|
@tomasklim done |
1e45c7e to
2c4608c
Compare
tomasklim
reviewed
Nov 4, 2024
Comment on lines
+88
to
+91
| // Define signature constants | ||
| const STAKE_SIGNATURE = '0x3a29dbae'; | ||
| const UNSTAKE_SIGNATURE = '0x76ec871c'; | ||
| const CLAIM_SIGNATURE = '0x33986ffa'; |
There was a problem hiding this comment.
Can those be added to your lib? and we just import it from @everstake/sdk?
There was a problem hiding this comment.
Agree, it could be added. But let's do this as a part of the separate PR. I remember we also had some hardcoded values in the blockbook that didn't belong to it.
tomasklim
reviewed
Nov 4, 2024
| return isStakeTypeTx(signature) ? signatureToStakeNameMap[signature] : null; | ||
| }; | ||
|
|
||
| export const getUnstakeAmountByEthereumDataHex = (dataHex?: string) => { |
There was a problem hiding this comment.
I think some of those utils would be interesting for your sdk or not?
There was a problem hiding this comment.
yeah, you're right. But let's do it separately
tomasklim
approved these changes
Nov 4, 2024
|
You have unused dependencies error @dev-pvl |
2c4608c to
7d6c59a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combined all stake utils into a single file.
Moved constants into wallet-constants and pulled non-type items out of type files.
Renamed a few files to make things easier to find
Related Issue
Resolve #13754