Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify staking files #13754

Closed
tomasklim opened this issue Aug 10, 2024 · 4 comments · Fixed by #15108
Closed

Unify staking files #13754

tomasklim opened this issue Aug 10, 2024 · 4 comments · Fixed by #15108
Labels
code Code improvements staking

Comments

@tomasklim
Copy link
Member

tomasklim commented Aug 10, 2024

Right now utils and types are all over suite in many files.

Please unify as much as possible.

There is stake.ts utils file in packages/suite
There is stake.ts utils file in @suite-common/suite-utils
Then there is stakingUtils.ts in @suite-common/wallet-utils

There is stake.ts utils file in @suite-common/wallet-types
There is stakeTypes.ts utils file in @suite-common/wallet-core

  • there are also values which are definitely not types in this file. Maybe should be in file ethStaking.ts

The file with constants ethStaking.ts is also hard to find, please come up with better naming

Please do some kind of cleaning and organising so that it is easy to find what we are looking for.

@tomasklim tomasklim converted this from a draft issue Aug 10, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Aug 10, 2024
@tomasklim tomasklim changed the title Unify staking utils file Unify staking files Aug 10, 2024
@sime sime added the code Code improvements label Aug 14, 2024
@omykhailovskyi
Copy link

Please add acceptance criteria, as discussed

@sime
Copy link
Contributor

sime commented Oct 2, 2024

Please add acceptance criteria, as discussed

@tomasklim

@tomasklim
Copy link
Member Author

@dev-pvl @omykhailovskyi

as discussed, create files for eth staking utils and generic staking utils. Same for types.

@tomasklim tomasklim removed their assignment Oct 11, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🥩 Staking Nov 4, 2024
@bosomt
Copy link
Contributor

bosomt commented Nov 5, 2024

QA OK

Stake and unstake THOL OK

Info:

  • Suite version: web 24.11.0 (c584547)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T1B1 1.12.1 regular (revision 1eb0eb9d91b092e571aac63db4ebff2a07fd8a1f)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements staking
Projects
Archived in project
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants