-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify staking files #13754
Comments
Please add acceptance criteria, as discussed |
|
as discussed, create files for eth staking utils and generic staking utils. Same for types. |
QA OK Stake and unstake THOL OK Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now utils and types are all over suite in many files.
Please unify as much as possible.
There is
stake.ts
utils file inpackages/suite
There is
stake.ts
utils file in@suite-common/suite-utils
Then there is
stakingUtils.ts
in@suite-common/wallet-utils
There is
stake.ts
utils file in@suite-common/wallet-types
There is
stakeTypes.ts
utils file in@suite-common/wallet-core
ethStaking.ts
The file with constants
ethStaking.ts
is also hard to find, please come up with better namingPlease do some kind of cleaning and organising so that it is easy to find what we are looking for.
The text was updated successfully, but these errors were encountered: