Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/jumping evm fee #11999

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix/jumping evm fee #11999

merged 2 commits into from
Apr 16, 2024

Conversation

tomasklim
Copy link
Member

Description

  • for some tokens simulation does not return fee, let's put there backup gas limit
  • when changing amount of tokens, gas limit is jumping to 21000 and back, let's not do this, let's return logic from before

Related Issue

Fixing two bugs introduced by #11759 and #11897

Screenshots:

Screenshot 2024-04-12 at 14 31 42

Screen.Recording.2024-04-12.at.14.32.08.mov

@tomasklim tomasklim requested a review from AdamSchinzel April 12, 2024 12:33
@tomasklim tomasklim force-pushed the fix/jumping-evm-fee branch 2 times, most recently from e855123 to a35466e Compare April 12, 2024 13:58
@tomasklim tomasklim force-pushed the fix/jumping-evm-fee branch from a35466e to 2a8320a Compare April 15, 2024 08:20
Copy link
Contributor

@AdamSchinzel AdamSchinzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @enjojoy maybe it would be great to notify user's that we set these values for them because estimation failed.

@tomasklim tomasklim merged commit 092b861 into develop Apr 16, 2024
23 checks passed
@tomasklim tomasklim deleted the fix/jumping-evm-fee branch April 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants