fix(suite): use estimated gas limit for EVM token transfers #11897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trezor/qa please try to send some tokens on MATIC and ETH network 🙏 |
Closed
|
QA NOK ETH
POLY tested two tokens with default
Info:
|
|
@bosomt does sending data on polygon work? 🤯 |
|
@bosomt can you test again the tokens? I dont have that issue 😀 maybe record your steps |
|
Tried to send two random tokens that we got from airdrop. Info:
|
|
@tomasklim and sorry for late reply |
|
Okay, you are right, it works for some tokens and for some it does not. Especially it does not for some unrecognised. It needs an investigation. The problem is definitely not in Suite, maybe the contract of tokens is somehow modified for these scams. Applies to both ETH and MATIC
|
This was referenced Apr 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No idea why we had hardcoded value
200_000I am also suprised that there was no token which required more than
200_000