Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect): remove dead code #11975

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore(connect): remove dead code #11975

merged 1 commit into from
Apr 12, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Apr 11, 2024

while working on #11532 I noticed this little chunk of dead code.

releasePromise is not awaitable. It would need to be await releasePromise.promise. So I presume it is pretty safe to delete.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mroz22 mroz22 merged commit 4f0ee2e into develop Apr 12, 2024
72 of 73 checks passed
@mroz22 mroz22 deleted the connect/remove-dead-code branch April 12, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants