-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite-desktop): use node-bridge as primary transport #11532
Conversation
Can I still set it up in debug settings? |
We do not have any designs right now. Once Lukas is back, we'll create something. So either use the old designs or wait like 2 weeks for the designs. |
50aa6af
to
f5c21c1
Compare
8ba8962
to
892a921
Compare
892a921
to
ad082bd
Compare
3d12163
to
91de5a5
Compare
42ca71e
to
4b405f4
Compare
4b405f4
to
bc8bda5
Compare
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
bc8bda5
to
2ee2cb0
Compare
2ee2cb0
to
f57ffcd
Compare
8a2abee
to
3a935ad
Compare
3a935ad
to
5e33584
Compare
5e33584
to
2ae965f
Compare
2ae965f
to
8313445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
Another step in old bridge deprecation:
As of now, suite-desktop e2e tests already use the new node bridge and it is also possible already to force the new bridge using
--bridge-node
flag. However suite-desktop app in production would still start trezord-go binary on startup.--bridge-legacy
and--bridge-legacy-dev
(for emulator support)issues: