Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-desktop): use node-bridge as primary transport #11532

Merged
merged 1 commit into from
May 6, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Mar 11, 2024

Another step in old bridge deprecation:

  • ensure feature parity between old and new bridge
  • make new bridge run by default in desktop app

As of now, suite-desktop e2e tests already use the new node bridge and it is also possible already to force the new bridge using --bridge-node flag. However suite-desktop app in production would still start trezord-go binary on startup.

  • trezord-go is no longer started, trezor-suite starts node-bridge module which exposes the same interface as the old bridge instead
  • old bridge is stil runable using flags --bridge-legacy and --bridge-legacy-dev (for emulator support)

issues:

@Hannsek
Copy link
Contributor

Hannsek commented Mar 11, 2024

old bridge is stil runable using flags --bridge-legacy and --bridge-legacy-dev (for emulator support)

Can I still set it up in debug settings?

@Hannsek
Copy link
Contributor

Hannsek commented Mar 11, 2024

status page, this is not finished, do we have some design how it should look like, or should we just somehow receate the old stauts page? cc @Hannsek

We do not have any designs right now. Once Lukas is back, we'll create something. So either use the old designs or wait like 2 weeks for the designs.

@mroz22 mroz22 force-pushed the node-bridge-primary branch 5 times, most recently from 50aa6af to f5c21c1 Compare March 18, 2024 09:53
@mroz22 mroz22 force-pushed the node-bridge-primary branch 6 times, most recently from 8ba8962 to 892a921 Compare March 21, 2024 10:51
@mroz22 mroz22 force-pushed the node-bridge-primary branch from 892a921 to ad082bd Compare March 21, 2024 12:25
@mroz22 mroz22 force-pushed the node-bridge-primary branch from 3d12163 to 91de5a5 Compare March 22, 2024 08:52
@mroz22 mroz22 force-pushed the node-bridge-primary branch 4 times, most recently from 42ca71e to 4b405f4 Compare April 5, 2024 12:17
@trezor trezor deleted a comment from socket-security bot Apr 5, 2024
@mroz22 mroz22 force-pushed the node-bridge-primary branch from 4b405f4 to bc8bda5 Compare April 5, 2024 12:49
Copy link

socket-security bot commented Apr 5, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@mroz22 mroz22 force-pushed the node-bridge-primary branch from bc8bda5 to 2ee2cb0 Compare April 5, 2024 13:33
@mroz22 mroz22 force-pushed the node-bridge-primary branch from 2ee2cb0 to f57ffcd Compare April 11, 2024 10:21
@mroz22 mroz22 force-pushed the node-bridge-primary branch from 2ae965f to 8313445 Compare May 6, 2024 09:10
@mroz22 mroz22 marked this pull request as ready for review May 6, 2024 09:20
Copy link
Member

@martykan martykan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@mroz22 mroz22 merged commit d18561d into develop May 6, 2024
20 of 21 checks passed
@mroz22 mroz22 deleted the node-bridge-primary branch May 6, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🗒 Draft
Development

Successfully merging this pull request may close these issues.

3 participants