Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translations to de_DE #4800

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

leomelzer
Copy link
Contributor

Follow up to #4797 with new translation structure

Original text:

Thanks for making uppy! I appreciate the hard work and versatility.

When integrating this for a mobile PWA, I noticed two translation strings are missing which I've added to this PR. I hope you find this useful, too.

Thanks,
Leo

Thanks for the initial review @Acconut!

Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks!

@arturi arturi merged commit 8f4a10f into transloadit:main Nov 22, 2023
15 checks passed
@leomelzer leomelzer deleted the patch-1 branch November 22, 2023 16:09
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
github-actions bot added a commit that referenced this pull request Nov 24, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/companion-client |   3.6.1 | @uppy/store-default    |   3.1.0 |
| @uppy/locales          |   3.5.0 | uppy                   |  3.20.0 |

- meta: uppy CDN: Export UIPlugin and BasePlugin (Artur Paikin / #4774)
- @uppy/locales: Add missing translations to de_DE (Leonhard Melzer / #4800)
- @uppy/store-default: refactor to typescript (Antoine du Hamel / #4785)
- meta: improve js2ts script (Antoine du Hamel / #4786)
- @uppy/companion-client: fix log type error (Mikael Finstad / #4766)
- @uppy/companion-client: revert breaking change (Antoine du Hamel / #4801)
- @uppy/locales: use TypeScript for source files (Antoine du Hamel / #4779)
- meta: migrate AWS SDK v2 to v3 in `bin/uploadcdn` (Trivikram Kamat / #4776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants