Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in bin folder #4776

Merged
merged 4 commits into from
Nov 14, 2023
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in bin folder #4776

merged 4 commits into from
Nov 14, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 6, 2023

Issue

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Description

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx aws-sdk-js-codemod@0.26.1 -t v2-to-v3 bin/upload-to-cdn.js

Additional Context

@uppy/companion switched to AWS SDK for JavaScript v3 in #4285

@trivikr trivikr marked this pull request as ready for review November 6, 2023 02:19
Copy link

socket-security bot commented Nov 6, 2023

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: aws-sdk@2.1495.0

@trivikr
Copy link
Contributor Author

trivikr commented Nov 13, 2023

cc active contributors @arturi @aduh95

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM

@aduh95 aduh95 merged commit 736a1bc into transloadit:main Nov 14, 2023
19 checks passed
@trivikr trivikr deleted the aws-sdk-js-codemod branch November 14, 2023 16:22
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
github-actions bot added a commit that referenced this pull request Nov 24, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/companion-client |   3.6.1 | @uppy/store-default    |   3.1.0 |
| @uppy/locales          |   3.5.0 | uppy                   |  3.20.0 |

- meta: uppy CDN: Export UIPlugin and BasePlugin (Artur Paikin / #4774)
- @uppy/locales: Add missing translations to de_DE (Leonhard Melzer / #4800)
- @uppy/store-default: refactor to typescript (Antoine du Hamel / #4785)
- meta: improve js2ts script (Antoine du Hamel / #4786)
- @uppy/companion-client: fix log type error (Mikael Finstad / #4766)
- @uppy/companion-client: revert breaking change (Antoine du Hamel / #4801)
- @uppy/locales: use TypeScript for source files (Antoine du Hamel / #4779)
- meta: migrate AWS SDK v2 to v3 in `bin/uploadcdn` (Trivikram Kamat / #4776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants