@uppy/image-editor: Add image editor cancel event #3875
Conversation
website/src/docs/image-editor.md
Outdated
| @@ -121,6 +121,16 @@ uppy.on('file-editor:complete', (updatedFile) => { | |||
| }) | |||
| ``` | |||
|
|
|||
| ### file-editor:cancel | |||
|
|
|||
| Emitted when `uninstall` is called. | |||
There was a problem hiding this comment.
Shouldn't we also call this event when you are editing, but discard the changes?
There was a problem hiding this comment.
I'm trying to use this with uppy dashboard and it does not fire when changes are discarded. I might have understood it wrong but this event does not get triggered at all @Murderlon.
This is what I'm trying to test with
uppy.on("file-editor:cancel", (e) => {
console.log("CANCEL")
})and hitting this button is when I'm expecting it to get called
There was a problem hiding this comment.
Are you on the latest version?
There was a problem hiding this comment.
Sorry for the late reply, I'm on 2.13.4 @Murderlon
There was a problem hiding this comment.
Can you update to latest 2.x (or 3.x) and try again?
There was a problem hiding this comment.
2.3.3 is the latest which I'm on. Are you able to repro this when using the image editor with dashboard @Murderlon?
|
Hmm... I am not sure if we should emit the |
No I don't think so |
Co-authored-by: Merlijn Vos <merlijn@soverin.net>
Alright, got it! |
|
Thank you! |
| Package | Version | Package | Version | | ------------------ | ------- | ------------------ | ------- | | @uppy/dashboard | 2.4.0 | @uppy/robodog | 2.9.0 | | @uppy/image-editor | 1.4.0 | uppy | 2.13.0 | | @uppy/transloadit | 2.3.4 | | | - @uppy/transloadit: fix outdated file ids and incorrect usage of files (Merlijn Vos / #3886) - @uppy/image-editor: remove beta notice (Merlijn Vos / #3877) - meta: Fix broken links in _posts/2019-08-1.3.md (YukeshShr / #3884) - meta: Fix broken link in _posts/2017-03-0.15.md (YukeshShr / #3883) - @uppy/image-editor: Add image editor cancel event (James R T / #3875)
This PR adds a
cancelevent to the@uppy/image-editorpackage. This should close #3846.Do let me know if I missed anything or if any further changes are required.
Thank you!