Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/image-editor - Cancel Event #3846

Closed
oalexdoda opened this issue Jun 23, 2022 · 1 comment · Fixed by #3875
Closed

@uppy/image-editor - Cancel Event #3846

oalexdoda opened this issue Jun 23, 2022 · 1 comment · Fixed by #3875
Labels
Feature Good first issue We expect that this could be implemented without deep knowledge of the existing codebase Help Wanted Indicates that we’d especially appreciate community input in this issue

Comments

@oalexdoda
Copy link

Hey, can you guys add a cancel event to this? Thanks!

uppy.on('file-editor:cancel', () => {
    console.log('File Editor Cancelled')
})

Thanks!
@Murderlon
Copy link
Member

I think we can add that, yes. Can you create a PR for it?

@aduh95 aduh95 added Help Wanted Indicates that we’d especially appreciate community input in this issue Good first issue We expect that this could be implemented without deep knowledge of the existing codebase labels Jul 6, 2022
@jamestiotio jamestiotio mentioned this issue Jul 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Good first issue We expect that this could be implemented without deep knowledge of the existing codebase Help Wanted Indicates that we’d especially appreciate community input in this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@uppy/image-editor: Add image editor cancel event jamestiotio/uppy
3 participants
@oalexdoda @Murderlon @aduh95