INT B-21416 intl crating tio update for payment request-FE- PART 2 #14824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21416
Summary
This is to fix a small bug that caused service item label to show label of the 1st service item on the list instead of each being separate on the payment request page. This was because the existing code was filtering based on the service item Code and not by the ID. So multiple of the same service item within a payment request would always fetch the 1st one one the list.
For example, International Crating service item should have a label of
International Crating
and International Crating service item that is aStandalone
should have a labelInternational Crating - Standalone
. But it was showingInternational Crating - Standalone
for both service items because that service item was 1st on the list.How to test
International crating
service item, but this time don't choose thestandalone
option.International crating
and another withInternational crating - Standalone
Screenshots