Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21416 intl crating tio update for payment request-FE- PART 2 #14824

Conversation

taeJungCaci
Copy link
Contributor

@taeJungCaci taeJungCaci commented Feb 14, 2025

B-21416

Summary

This is to fix a small bug that caused service item label to show label of the 1st service item on the list instead of each being separate on the payment request page. This was because the existing code was filtering based on the service item Code and not by the ID. So multiple of the same service item within a payment request would always fetch the 1st one one the list.

For example, International Crating service item should have a label of International Crating and International Crating service item that is a Standalone should have a label International Crating - Standalone. But it was showing International Crating - Standalone for both service items because that service item was 1st on the list.

How to test

  1. As a customer -> create any move with a iHHG shipment.
  2. As a SC -> edit and submit.
  3. As a TOO -> Approve and send to prime.
  4. As a Prime -> add service item to the shipment and choose International Crating on the dropdown.
  5. Fill out the form - make sure item size is less than the crating size. Also choose 'standalone' option.
  6. Create another International crating service item, but this time don't choose the standalone option.
  7. As a TOO -> approve these service items added.
  8. As a Prime -> Request payment for both the service items.
  9. As a TIO -> review the payment request.
  10. Verify the labels show International crating and another with International crating - Standalone

Screenshots

image
image

@taeJungCaci taeJungCaci self-assigned this Feb 14, 2025
@taeJungCaci taeJungCaci added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Feb 14, 2025
@taeJungCaci taeJungCaci marked this pull request as ready for review February 14, 2025 18:52
@taeJungCaci taeJungCaci requested a review from a team as a code owner February 14, 2025 18:52
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taeJungCaci taeJungCaci merged commit 175850a into integrationTesting Feb 14, 2025
6 checks passed
@taeJungCaci taeJungCaci deleted the INT-B-21416-intl-crating-TIO-update-for-payment-request branch February 14, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants