MAIN B-21416 intl crating tio update for payment request-FE #14765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
…MAIN-B-21416-intl-crating-TIO-update-for-payment-request
taeJungCaci
commented
Feb 19, 2025
Comment on lines
+58
to
+59
| MarketOrigin: 'MarketOrigin', | ||
| MarketDest: 'MarketDest', |
There was a problem hiding this comment.
Reason for this not showing up in my INT PRs - this was already in IntegrationBranch from a different Feature.
r-mettler
approved these changes
Feb 19, 2025
JamesHawks224
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21416
INT PR:
#14766
#14824
Summary
This is the FE portion of the implementation done on B-22020.
Displays international crating/uncrating service item payment request param information in TIO payment request review page.
Note: External crating is subject to 4 cubic ft min and all the others are not. Meaning if you select 'External Crate' option when creating the service item, it will charge as 4 cubic ft if the crate size is lower than that.
How to test
NOTE: So currently the crate size - cu ft is allowed 2 decimal places (ex. 0.01) which means it will calculate correctly if the dimensions are at least about 2.6 x 2.6 x 2.6 inches. If you put any lower size than this you will get a cu ft size of 0.00 which will result in $0 for the total amount.
2600for each L, W, H. Also chooseexternal crateand 'standalone' option.International cratingservice item, but this time don't choose theexternal crateorstandaloneoption and put 2600 or greater for each L, W, H.International uncratingservice item and put at least 2600 for each sizes.If you have selected "External crate" option for International Crating and have chosen dimensions that is less than 4 cu ft, that you should see
Crating size (cu ft) - Minimum 4.00,Actual size,External crate, andMinimum crating size appliedlabels.You should also see
OCONUSlabel for ICRT if your pickup address isOCONUS. OtherwiseCONUS.You should also see
OCONUSlabel for IUCRT if your destination address isOCONUS. OtherwiseCONUS.Screenshots
Crating
Uncrating
