Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pdfcpu fork to relaxed outline validation #14741

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

cameroncaci
Copy link
Contributor

@cameroncaci cameroncaci commented Feb 4, 2025

Ticket?

No ticket, this is just a discovered problem

Code changes?

Here, this commit in the fork transcom/pdfcpu@1a00605

Summary

We apparently have some PDFs floating around that violate the "Outlines" PDF dictionary requirement. I set the fork to relax this validation as it does not negatively impact the file itself. It is the fault of the PDF writer of whoever made the faulty PDF, but since it still works when opening and such, we'll relax the validation. This is similar to the issue reported here pdfcpu/pdfcpu#1089

How to test

  1. Make a PPM as a new customer
  2. Upload this attachment as your orders Testing Document.pdf
  3. Proceed through the flow until you are told as the customer to upload PPM docs (weight tickets)
  4. Upload this attachment as your EMPTY WEIGHT TICKET, yes the order matters sample (1).pdf
  5. Upload this attachment as your FULL WEIGHT TICKET, yes the order matters outlines-with-loop (1).pdf
  6. Finish the PPM closeout and then download your payment packet. It should NOT error 😃
  7. Want to break it? Do the steps above but in a different branch

@cameroncaci cameroncaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Feb 4, 2025
@cameroncaci cameroncaci requested a review from a team February 4, 2025 21:09
@cameroncaci cameroncaci self-assigned this Feb 4, 2025
@cameroncaci cameroncaci requested a review from a team as a code owner February 4, 2025 21:09
@cameroncaci cameroncaci changed the title set fork to relaxed outline validation set pdfcpu fork to relaxed outline validation Feb 4, 2025
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to successfully download the payment packet using the provided PDFs

@cameroncaci cameroncaci merged commit 74d2fb5 into integrationTesting Feb 7, 2025
6 checks passed
@cameroncaci cameroncaci deleted the relaxed-outline-validation-int branch February 7, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants