Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B21575-INT3B-add order type #14378

Merged
merged 14 commits into from
Dec 12, 2024
Merged

B21575-INT3B-add order type #14378

merged 14 commits into from
Dec 12, 2024

Conversation

JamesHawks224
Copy link
Contributor

@JamesHawks224 JamesHawks224 commented Dec 11, 2024 •
edited
Loading

Agility ticket

B21575

Previous INT PR's

14211

Main PR's

14206

Summary

Main PR was updated to:

  • fix broken tests
  • fix linter errors

This PR was created install into integrationTesting the commits recently made in the main branch.

Testing

Per the changes listed, there is no functional change and therefore nothing to test.

@JamesHawks224 JamesHawks224 added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Dec 11, 2024
@JamesHawks224 JamesHawks224 marked this pull request as ready for review December 11, 2024 22:15
@JamesHawks224 JamesHawks224 requested review from a team as code owners December 11, 2024 22:15
@robot-mymove
Copy link

robot-mymove commented Dec 11, 2024 •
edited
Loading

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against d7992c8

@robot-mymove
Copy link

robot-mymove commented Dec 11, 2024 •
edited
Loading

Test coverage on server failed.

Last run: Thu 12 Dec 2024 06:04:33 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

KonstanceH
KonstanceH approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WeatherfordAaron
WeatherfordAaron approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

@JamesHawks224 JamesHawks224 merged commit 4f88b1e into integrationTesting Dec 12, 2024
33 of 34 checks passed
@JamesHawks224 JamesHawks224 deleted the B21575-INT3B-Add_order_type branch December 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@KonstanceH KonstanceH KonstanceH approved these changes

@WeatherfordAaron WeatherfordAaron WeatherfordAaron approved these changes

Assignees
No one assigned
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JamesHawks224 @robot-mymove @danieljordan-caci @KonstanceH @WeatherfordAaron