Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B21575 int3 add order type #14211

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Conversation

JamesHawks224
Copy link
Contributor

@JamesHawks224 JamesHawks224 commented Nov 15, 2024

Agility ticket

B21575

Notes

This PR is a remake of prior PR. Prior PR was: 14164

Summary

For the customer, 2 new order types were added: Student Travel, Early Return of Dependents. If either of these were selected, then "Has Dependents" would default to "yes" and be disabled so it can't be changed. If another order type besides these 2 were selected, "Has Dependents" would be re-enabled and would be reset to nothing selected.

How to test

In the .envrc.local file, add the following to turn on the feature flag:
export FEATURE_FLAG_ENABLE_ALASKA=true
restart server and client

Scenario 1: Creating a move

  • login as a customer
  • create a move
  • at the move orders page ("tell us about your move orders")
    • set initial values all fields:
      • order type: Permanent Change of Station
      • remaining fields: any value is fine
  • verification
    • verify: order type, changing existing type to another existing type
      • change order type to local move
      • verify no fields are changed
    • verify: order type, changing existing type to new type (student travel)
      • change order type to student travel
      • verify "are dependents included" defaults to "yes"
      • verify "are dependents included" is disabled
    • verify: order type, changing new type (student travel) to existing type
      • change order type to permanent change of station
      • verify "are dependents included" defaults to no selection
      • verify "are dependents included" is enabled
    • verify: order type, changing existing type to new type (early return of dependents)
      • change order type to student travel
      • verify "are dependents included" defaults to "yes"
      • verify "are dependents included" is disabled
    • verify: order type, changing new type (early return of dependents) to existing type
      • change order type to permanent change of station
      • verify "are dependents included" defaults to no selection
      • verify "are dependents included" is enabled
    • verify: order type, changing new type (early return of dependents) to to new type (student travel)
      • change order type to early return of dependents
      • verify "are dependents included" defaults to "yes"
      • verify "are dependents included" is disabled
      • change order type to student travel
      • verify "are dependents included" defaults to "yes"
      • verify "are dependents included" is disabled
  • finish creating the move w/a ppm shipment.

Scenario 2: edit existing orders

  • login as a customer
  • use the move just created in scenario 1
  • click on "review your request"
  • edit orders
  • on the "edit orders" page, set the initial values the same as in scenario 1
  • perform verification the same verification as in scenario 1.
  • save the page

Scenario 3: turn off feature flag
In the .envrc.local file, add the following to turn on the feature flag:
export FEATURE_FLAG_ENABLE_ALASKA=false
restart server and client

  • Create a move: On the orders page, verify neither Student Travel or Early Return of Dependents shows up in the drop down list
  • Edit a move: On the orders page, verify neither Student Travel or Early Return of Dependents shows up in the drop down list

ANDI Screenshots

Creating a move:
image

Editing existing orders:
image

Testing Screenshots

N/A

@JamesHawks224 JamesHawks224 added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Nov 15, 2024
@JamesHawks224 JamesHawks224 marked this pull request as ready for review November 20, 2024 19:36
@JamesHawks224 JamesHawks224 requested a review from a team as a code owner November 20, 2024 19:36
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JamesHawks224 JamesHawks224 merged commit c61e813 into integrationTesting Nov 21, 2024
30 checks passed
@JamesHawks224 JamesHawks224 deleted the B21575-INT3-Add_order_type branch November 21, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants