-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B21575 int3 add order type #14211
Merged
JamesHawks224
merged 13 commits into
integrationTesting
from
B21575-INT3-Add_order_type
Nov 21, 2024
Merged
B21575 int3 add order type #14211
JamesHawks224
merged 13 commits into
integrationTesting
from
B21575-INT3-Add_order_type
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to B21575-INT3-Add_order_type
begrohmann
approved these changes
Nov 21, 2024
deandreJones
approved these changes
Nov 21, 2024
brooklyn-welsh
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
B21575
Notes
This PR is a remake of prior PR. Prior PR was: 14164
Summary
For the customer, 2 new order types were added: Student Travel, Early Return of Dependents. If either of these were selected, then "Has Dependents" would default to "yes" and be disabled so it can't be changed. If another order type besides these 2 were selected, "Has Dependents" would be re-enabled and would be reset to nothing selected.
How to test
In the .envrc.local file, add the following to turn on the feature flag:
export FEATURE_FLAG_ENABLE_ALASKA=true
restart server and client
Scenario 1: Creating a move
Scenario 2: edit existing orders
Scenario 3: turn off feature flag
In the .envrc.local file, add the following to turn on the feature flag:
export FEATURE_FLAG_ENABLE_ALASKA=false
restart server and client
ANDI Screenshots
Creating a move:
![image](https://private-user-images.githubusercontent.com/146897935/382845311-7eaf2b15-612b-4558-95d7-ecaeb938f7b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTU5MjIsIm5iZiI6MTczOTI1NTYyMiwicGF0aCI6Ii8xNDY4OTc5MzUvMzgyODQ1MzExLTdlYWYyYjE1LTYxMmItNDU1OC05NWQ3LWVjYWViOTM4ZjdiOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwNjMzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01MzkzYWI2YjMxNTNjZjVmOWRlNGVlY2M1NTViZjY5MGM1N2M0NTI5ZTgzNTNiOGJiYTM1NzRmYTczNTljYWM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.7zF1O6-f8msk7Pgc9hSK0DO1_3z5SLV2sLpEADUg140)
Editing existing orders:
![image](https://private-user-images.githubusercontent.com/146897935/382931916-b71fc586-4274-4705-87b6-80e0eea0ffc0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTU5MjIsIm5iZiI6MTczOTI1NTYyMiwicGF0aCI6Ii8xNDY4OTc5MzUvMzgyOTMxOTE2LWI3MWZjNTg2LTQyNzQtNDcwNS04N2I2LTgwZTBlZWEwZmZjMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwNjMzNDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNjM1YmY5YTlkMjIzNGU3OTdiMmRmMzcwNjM1YWVhYmQ0ZDM5OTA5MGZiMDA0MjRlYmYzYTg4ZjkxMTI0MDgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Mq9hOtZwy_kW2MvsSs7l_DHsjouEmB2VKHU4DBxgiKo)
Testing Screenshots
N/A