B 21393 - Consolidated PPM Allowable Weights #14335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in ppm_shipments" This reverts commit 9a2bfda.
…d services to use value from the ppm shipment
…s some generated files
|
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
antgmann
approved these changes
Dec 4, 2024
|
The INT PR had these lines commented out but in the main PR and in current INT they are not. Other than this the changes match. |
r-mettler
approved these changes
Dec 5, 2024
|
Some storybook failures to look into with this one. |
These seem to have been introduced elsewhere, there is a fix on INT but not in main. Not sure why it's showing up now. There is also a fix in my 21490 PR so getting that into main then should resolve it here. |
…and are causing playwright failures
|
"do not merge" tag was added due to two playwright failures that did not exist on the integration PR for this backlog. The failures were caused by two lines existed in main that did not exist in integrationTesting. They were removed in a merge conflict fix that doesn't seem to have made it to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21393
INT PR 1
INT PR 2
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots