B 20972 tio ppm #14217
Merged
B 20972 tio ppm #14217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in upstream
Experimental changes reversed. updating from main
Merge latest main
Merge to avoid future conflicts
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
ajlusk
approved these changes
Dec 11, 2024
MInthavongsay
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20972
INT PR
Main-PR Specific Information
This PR was delayed for merging to main due to being downstream in implementation to B-21393. As a result, there had to be an additional commit to resolve merge conflicts between main and this branch. The commit, e2b4e77, only alters src/components/Office/PPM/ReviewDocumentsSidePanel/ReviewDocumentsSidePanel.jsx. Please check the commit-specific changes for this file, and ensure that none of the commit changes relative to this branch reflect as changes between this branch and main. Once that is checked, we can be sure that the merge conflicts didn't meaningfully alter the changes from the branch relative to main. Please correct me if I'm wrong on this.
Summary
The main purpose of this ticket is to give TIOs the ability to do a read-only review of a PPM Shipment's documents and moving information when reviewing a shipment's weights.
Currently, when a TIO navigates to the Payment Requests page, and selects "Review shipment weights" under the Billable weight section, PPMs do not display any information whatsoever and are filtered out of the shipment list. This task prevents them from being filtered out, adjusts a query that retrieves PPM Shipment information + weight tickets to also retrieve pro gear weight tickets and moving expenses, compiles all of the documents per ppm shipment (rather than document set), and displays a read-only version of the Service Counselor's overview of a PPM Shipment's documents when they review shipment weights.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Screenshots
Canvas alert is for document viewer showing document. Disabled alerts are for SC editable fields the TIO cannot access.
Only color contrast error is on the same part of the page as it always is, the divider in the top left of the header. No new images were added with text to be read.
