Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B-21667 I-13574 INT #14277

Merged
merged 11 commits into from
Nov 26, 2024
Merged

B-21667 I-13574 INT #14277

merged 11 commits into from
Nov 26, 2024

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Nov 25, 2024 •
edited
Loading

Upstreams:
#14176
#14188
#14246

Agility issue

Agility ticket

Summary

Needed to update ubAllowance to unaccompaniedBaggageAllowance, after changing that variable name for the prime API as part of B-21487, which I have merged into my B-21667 branch.

How to test

  1. Login as a customer, creating a UB shipment with the UB FF turned on
  2. Log in as an SC and view the Allowances section for the move and check that you have an Unaccompanied baggage allowance
    image
  3. Click on the Edit shipment button
  4. Verify that the UB Weight Allowance shown at the top of the Edit Shipment Details page matches the number on the Allowances section
    image
  5. Do this for both SC and TOO

@traskowskycaci traskowskycaci self-assigned this Nov 25, 2024
@traskowskycaci traskowskycaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Nov 25, 2024
@traskowskycaci traskowskycaci changed the title B 21667 i 13574 int B-21667 I-13574 INT Nov 25, 2024
@traskowskycaci traskowskycaci marked this pull request as ready for review November 25, 2024 17:49
@robot-mymove
Copy link

robot-mymove commented Nov 25, 2024 •
edited
Loading

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against 9ac40f5

danieljordan-caci
danieljordan-caci approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bingo bango

Screenshot 2024-11-25 at 12 29 54 PM

cameroncaci
cameroncaci approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there!

Screenshot 2024-11-26 at 12 01 50 PM

@traskowskycaci traskowskycaci merged commit 0573a97 into integrationTesting Nov 26, 2024
30 checks passed
@traskowskycaci traskowskycaci deleted the B-21667-I-13574-INT branch November 26, 2024 18:16
@traskowskycaci traskowskycaci mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@cameroncaci cameroncaci cameroncaci approved these changes

@deandreJones deandreJones Awaiting requested review from deandreJones deandreJones was automatically assigned from transcom/mountain-movers

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

Assignees

@traskowskycaci traskowskycaci

Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@traskowskycaci @robot-mymove @danieljordan-caci @cameroncaci @ryan-mchugh @brianmanley-caci