B-21667 B-21374 I-13550 INT #14246
Merged
B-21667 B-21374 I-13550 INT #14246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Submit-Confirmation-Screen
…-Submit-Confirmation-Screen
…-Submit-Confirmation-Screen
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…-Submit-Confirmation-Screen
…-Submit-Confirmation-Screen
…-Submit-Confirmation-Screen
…ate-to-Customer-Submit-Confirmation-Screen B 21467 main ppm verbiage update to customer submit confirmation screen
|
The 0 value seems to be working for me. Non 0 values still display correctly. |
TevinAdams
approved these changes
Nov 20, 2024
This was referenced Nov 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility Issue
Agility ticket B-21667
Agility ticket B-21374
Summary
B-21374 fix
A mysterious 0 value was appearing on the allowance details in the case of 0 dependents under 12 and 0 over 12. Issue was written up for it, fix was just adding a > 0 for the each of the checks for info?.dependentsTwelveAndOver || info?.dependentsUnderTwelve in src/components/Office/DefinitionLists/AllowancesList.jsx.
B-21667 fix
As part of troubleshooting the above, noticed that the Unaccompanied Baggage Allowance field was not appearing on the Allowance section. Needed to update ubAllowance to unaccompaniedBaggageAllowance, after changing that variable as part of B-21487, which I have merged into my B-21667 branch.
How to test
Should NOT see this 0:
Try to break