Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21490 Office users can switch to their secondary duty locations (Review after B-21492) #14070

Merged
merged 60 commits into from
Nov 26, 2024

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Oct 31, 2024

B-21490

Summary

Office users are able to switch between their primary and secondary transportation office GBLOCs similar to an HQ user.

The bulk of the secondary transportation office changes were added in B-21492 and are also included in this PR.

Also includes G-Unit's B-21627 hotfix

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the admin app
  2. Create several office users of various roles each with two transportation offices. At least one should be a Services Counseling Supervisor.
  3. Log in as each of the users, toggle between your GBLOCs with the dropdown in the top right, switch between queues, export your queue, just try to break it.
  4. As your SC Supervisor verify the origin location dropdown filter's options update with the selected GBLOC.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@ajlusk ajlusk added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Oct 31, 2024
@ajlusk ajlusk self-assigned this Oct 31, 2024
@ajlusk ajlusk marked this pull request as ready for review November 6, 2024 21:00
@ajlusk ajlusk marked this pull request as draft November 7, 2024 15:23
@ajlusk
Copy link
Contributor Author

ajlusk commented Nov 7, 2024

Too many failures for it to be flaky, putting it back as draft temporarily.

@ajlusk ajlusk marked this pull request as ready for review November 26, 2024 04:22
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, testing steps work nicely

@antgmann antgmann merged commit 1fd1541 into integrationTesting Nov 26, 2024
28 of 29 checks passed
@antgmann antgmann deleted the B-21490-INT branch November 26, 2024 19:43
@ajlusk ajlusk restored the B-21490-INT branch December 4, 2024 19:57
@ajlusk ajlusk mentioned this pull request Dec 4, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

5 participants