B 19531 prime error #14280
Merged
B 19531 prime error #14280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in reusable changes
Merge latest main
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-19531
INT PR
Summary
This task has been repurposed since it's original creation in accordance with the fluctuation of DTOD changes. It is now a follow-on to B-20757 (see int pr 1, int pr 2 ), which takes the stopgap error message 20757 and also introduces it in the Prime Simulator for updating shipments.
Testing 20757 in our integration/loadtest environment has been tricky due to the current dtod implementation in that environment. This issue will likely hold up this ticket as well, but it can be tested on local environments with a little setup.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
distanceFloat = -1on line 124. This will simulate a dtod outage and allow us to continue testing. This is the step that makes testing tricky on other environments with their dtod setups.Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Screenshots
I don't know that ANDI is required for prime sim, but either way it passes:
