Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend default passenv to include SSL proxy vars #1437

Closed
ssbarnea opened this issue Oct 16, 2019 · 1 comment · Fixed by #1439
Closed

Extend default passenv to include SSL proxy vars #1437

ssbarnea opened this issue Oct 16, 2019 · 1 comment · Fixed by #1439
Labels
feature:new something does not exist yet, but should pr-merged

Comments

@ssbarnea
Copy link
Member

There is a list of 3 environment variables that are also needed for SSL proxies. Tox is currently passing proxy vars but missing to pass the SSL vars and the side effect is clear: called code will choke trying to verify the SSL certificates.

CURL_CA_BUNDLE
REQUESTS_CA_BUNDLE
SSL_CERT_FILE

I am fully aware that use can manually add them to their tox.ini file but this does not scale well at all when you have hundreds of repositories (like openstack for example).
@ssbarnea ssbarnea added the feature:new something does not exist yet, but should label Oct 16, 2019
@ssbarnea ssbarnea mentioned this issue Oct 16, 2019
Closed
ssbarnea added a commit to ssbarnea/tox that referenced this issue Oct 16, 2019
@ssbarnea
Adds SSL proxy variables to default passenv
e72b112 
This shouls avoid SSL failures with HTTP requests from pip, requests
or other libraries.

Also sorts existing values in order to make it easier to update the
list in the future.

Fixes: tox-dev#1437
ssbarnea added a commit to ssbarnea/tox that referenced this issue Oct 16, 2019
@ssbarnea
Adds SSL proxy variables to default passenv
05ee3bd 
This shouls avoid SSL failures with HTTP requests from pip, requests
or other libraries.

Also sorts existing values in order to make it easier to update the
list in the future.

Fixes: tox-dev#1437
@ssbarnea ssbarnea mentioned this issue Oct 16, 2019
Merged
6 tasks
@helpr helpr bot added the pr-available label Oct 16, 2019
ssbarnea added a commit to ssbarnea/tox that referenced this issue Oct 16, 2019
@ssbarnea
Adds SSL proxy variables to default passenv
749ba16 
This shouls avoid SSL failures with HTTP requests from pip, requests
or other libraries.

Also sorts existing values in order to make it easier to update the
list in the future.

Fixes: tox-dev#1437
@ssbarnea ssbarnea mentioned this issue Oct 17, 2019
Merged
webknjaz pushed a commit to ansible/ansible-lint that referenced this issue Oct 17, 2019
@ssbarnea @webknjaz
tox: addex SSL proxy variables to passenv
898caf5 
Fix tox execution failures from system that are using SSL based
http proxies.

Related: tox-dev/tox#1437
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
ssbarnea added a commit to ssbarnea/tox that referenced this issue Nov 1, 2019
@ssbarnea
Adds SSL proxy variables to default passenv
2b38dfe 
This shouls avoid SSL failures with HTTP requests from pip, requests
or other libraries.

Also sorts existing values in order to make it easier to update the
list in the future.

Fixes: tox-dev#1437
gaborbernat pushed a commit that referenced this issue Nov 11, 2019
@ssbarnea @gaborbernat
Adds SSL proxy variables to default passenv (#1439)
6feee0b 
This shouls avoid SSL failures with HTTP requests from pip, requests
or other libraries.

Also sorts existing values in order to make it easier to update the
list in the future.

Fixes: #1437
@helpr helpr bot added pr-merged and removed pr-available labels Nov 11, 2019
@gaborbernat
Copy link
Member

gaborbernat commented Nov 13, 2019 •
edited by unfurl-links bot
Loading

This now has been released under https://tox.readthedocs.io/en/latest/changelog.html#v3-14-1-2019-11-13

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature:new something does not exist yet, but should pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds SSL proxy variables to default passenv ssbarnea/tox
2 participants
@ssbarnea @gaborbernat