Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor setup.py #592

Closed
wants to merge 1 commit into from
Closed

Refactor setup.py #592

wants to merge 1 commit into from

Conversation

ssbarnea
Copy link
Member

Removes all workarounds from setup.py in order to avoid bugs like #590

tox.ini Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request fixes 1 alert when merging ba2d269 into 07b5194 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request fixes 1 alert when merging d30ee15 into 07b5194 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@ssbarnea ssbarnea marked this pull request as ready for review October 16, 2019 19:04
@ssbarnea ssbarnea requested a review from webknjaz as a code owner October 16, 2019 19:04
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we can go for it given the number of envs that are currently supported.

.travis.yml Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2019

This pull request fixes 1 alert when merging 008e4fc into 07b5194 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2019

This pull request fixes 1 alert when merging 265db1e into 07b5194 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2019

This pull request fixes 1 alert when merging b247e64 into 07b5194 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

setup.cfg Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2019

This pull request fixes 1 alert when merging 3e4ce6d into 898caf5 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

Removes all workarounds from setup.py in order to avoid bugs like #590

Prevents regressions by adding extra testing on Travis:
- installation from source
- installation as editable
- installation as pre-commit hook

Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
@ssbarnea ssbarnea requested a review from webknjaz October 17, 2019 22:42
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not deprecating supported envs at this time. To proceed, convince folks from Galaxy.

@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2019

This pull request fixes 1 alert when merging e8cd713 into ef356c5 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@webknjaz
Copy link
Member

We cannot accept this atm but this example is good for reference for what we can do in the future. Closing, for now, we can reopen it later once somebody has time to work on fixing the shim or its removal is approved by a higher power.

@webknjaz webknjaz closed this Oct 22, 2019
def cut_local_version_on_upload(version):
"""Generate a PEP440 local version if uploading to PyPI."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not exactly true. It's more like "cut off a local version on upload"

setup.cfg Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants