-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor setup.py #592
Refactor setup.py #592
Conversation
This pull request fixes 1 alert when merging ba2d269 into 07b5194 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging d30ee15 into 07b5194 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we can go for it given the number of envs that are currently supported.
This pull request fixes 1 alert when merging 008e4fc into 07b5194 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 265db1e into 07b5194 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging b247e64 into 07b5194 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 3e4ce6d into 898caf5 - view on LGTM.com fixed alerts:
|
Removes all workarounds from setup.py in order to avoid bugs like #590 Prevents regressions by adding extra testing on Travis: - installation from source - installation as editable - installation as pre-commit hook Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not deprecating supported envs at this time. To proceed, convince folks from Galaxy.
This pull request fixes 1 alert when merging e8cd713 into ef356c5 - view on LGTM.com fixed alerts:
|
We cannot accept this atm but this example is good for reference for what we can do in the future. Closing, for now, we can reopen it later once somebody has time to work on fixing the shim or its removal is approved by a higher power. |
def cut_local_version_on_upload(version): | ||
"""Generate a PEP440 local version if uploading to PyPI.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exactly true. It's more like "cut off a local version on upload"
Removes all workarounds from setup.py in order to avoid bugs like #590