Fix TCPConnection for verify_ssl = false #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 16 16
Lines 1003 1003
=======================================
Hits 938 938
Misses 65 65Continue to review full report at Codecov.
|
There was a problem hiding this comment.
As you can see in the preamble of this file, it is auto-generated by swagger-codegen. We shouldn't edit it directly but fix the generator and regenerate this library. It'll took some time so to not block you to use this library, I will merge it for the time being.
Thanks for your contribution!
kubernetes_asyncio/client/rest.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| No description provided (generated by Swagger Codegen https://github.com/swagger-api/swagger-codegen) # noqa: E501 | |||
|
|
|||
| OpenAPI spec version: v1.10.1 | |||
|
|
|||
There was a problem hiding this comment.
Could you rollback this unnecessary change ?
There was a problem hiding this comment.
hah sure, that was just editor auto trimming trailing whitespace
kubernetes_asyncio/client/rest.py
Outdated
| ssl_context=ssl_context, | ||
| verify_ssl=configuration.verify_ssl | ||
| ssl_context=ssl_context if configuration.verify_ssl else None, | ||
| verify_ssl=configuration.verify_ssl, |
There was a problem hiding this comment.
... and this , too. Small and precise change-set is simpler to read and apply. Thank you.
9bd2203 to
23ad462
Compare
|
I must admit I totally missed that comment. I will also go upstream in swagger codegen - thanks for being open to this PR regardless (track that here: swagger-api/swagger-codegen#8507) |
|
LGTM |
This fixes #32
I didn't see any relevant tests but am happy to add any test that you think should be here - unfamiliar with working in this library so I wouldn't know what makes the most sense off hand : )