Fix aiohttp client for verify_ssl=False #8507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master. (I'm guessing I'm doing it right? This is general rather than 3.0 related)Description of the PR
The async client is currently broken if verify_ssl is False, because aiohttp raises an exception if both verify_ssl is False and an ssl_context is passed to the client:
https://github.com/aio-libs/aiohttp/blob/5d5bb4674d11a9a2576266a1a51174af551262eb/aiohttp/client_reqrep.py#L120
Ergo, this makes sure we don't pass an ssl_context when verify_ssl is false.
Happy to add any tests you think might be necessary, just let me know what would be best - unfamiliar with working in this repo :)