Use framework imports where available [Fix use_frameworks!]
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked the CI failure. Unrelated to my changes, same error occurs on current master. |
|
This gets the green light from me. |
|
Cool :) |
|
Awesome! 👍 |
0587377 to
1193c0b
Compare
|
Good work @timbodeit , looking forward to seeing this PR merged 😄 |
|
@Stunner please have a quick look over the Readme changes. If you don't have any objections, this should be good to merge now. Pushed a new NUIParse release earlier today, so once this is merged, using NUI as a framework in Swift should work fine. |
When using the new `use_frameworks!` option in Cocoapods, by default errors about non-module imports are thrown, whenever a header is importet with "" that does not belong to the same module (same target) To circumvent this, import dependencies using </> when possible
- Improved documentation on usage with swift - Replace reference to CoreParse with NUIParse (fix tombenner#278)
a759fab to
edf0aee
Compare
Open
Stunner
added a commit
that referenced
this pull request
Nov 20, 2015
Use framework imports where available [Fix `use_frameworks!`]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new
use_frameworks!option in Cocoapods, by default errorsabout non-module imports are thrown, whenever a header is imported with "" that
does not belong to the same module (same target)
To circumvent this, import dependencies using </> when possible
This is one of the two changes, that fixed #303 for me. I have been using this off my own fork for about 5 months now.
The other part is sitting in the NUIParse#2 from roughly around the same time, that I originally made this commit.
The second part might be optional for Objective-C only projects, but is definitely needed for Swift projects, that use the native import syntax (and not a bridging header).
If @tombenner or anybody else with push access to NUIParse is looking at this, please also have a look at NUIParse#2.