Move NUIPSenTestKitAssertions to NUIParseTests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that this header relies on the SenTesingKit framwork, leads me to the conclusion, that it is not meant to be used anywhere else than in unit testing targets. It defines UnitTest assertions, that to my knowledge are only used in NUIPSTAssertionsTests.m Because this file was caught by the source_files pattern of the podspec file, it is included in the umbrella headers generated by cocoapods when applying the new 'use_framworks!' option. This leads to an error, because you normally wouldn't link the framework itself against the SenTesingKit framework, but it is automatically imported. I thus moved it to the unit test target folder, where IMHO it belongs anyways.
This was referenced Oct 31, 2015
|
👍 |
timbodeit
added a commit
that referenced
this pull request
Nov 6, 2015
Move NUIPSenTestKitAssertions to NUIParseTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that this header relies on the SenTesingKit framwork, leads me to the
conclusion, that it is not meant to be used anywhere else than in unit testing
targets.
It defines UnitTest assertions, that to my knowledge are only used in
NUIPSTAssertionsTests.mBecause this file was caught by the source_files pattern of the podspec file,
it is included in the umbrella headers generated by cocoapods when applying the
new
use_framworks!option.This leads to an error, because you normally wouldn't link the framework itself
against the SenTesingKit framework, but it is automatically imported.
I thus moved it to the unit test target folder, where IMHO it belongs anyways.