Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep watching geojson causes performance issues and circular reference errors #595

Closed
facultymatt opened this issue Jan 9, 2015 · 3 comments

Comments

@facultymatt
Copy link

Currently the geojson preforms a deep watch, as you can see here by the true value.

This causes performance issues with large complex objects.

It causes maximum stack errors on object that have circular references.

Is it possible to remove the deep watch, and still get the desired behavior?

@tombatossals
Copy link
Owner

Yes @facultymatt, you're totally right. I'm going to change the deep $watch by the $watchCollection shallow watcher.

Thanks for reporting.

tombatossals added a commit that referenced this issue Jan 13, 2015
@facultymatt
Copy link
Author

Thanks so much! Any word on a release date for this change?

On Tuesday, January 13, 2015, David Rubert notifications@github.com wrote:

Closed #595
#595.


Reply to this email directly or view it on GitHub
#595 (comment)
.

Matt Miller

Web Master
609-335-4417
matt@superpedestrian.com
https://www.superpedestrian.com/
https://www.google.com/url?q=https%3A%2F%2Fwww.superpedestrian.com%2F&sa=D&sntz=1&usg=AFQjCNHLEDFaMLgggeXL8rh4gGlNfN0WSA


Superpedestrian Inc.
84 Hamilton St.
Cambridge, MA 02139

This message is intended only for the addressee named above. If you are
not the intended recipient of this message, you are hereby notified that
you must not use, disseminate, or copy it in any form or take any action in
reliance upon it. If you have received this message in error, please
delete it and any copies of it from your email system and reply immediately
to the sender at the address shown above. This message may contain
confidential and/or proprietary information. Neither confidentiality, nor
any proprietary rights are intended to be waived or lost by any error in
transmission.

@tombatossals
Copy link
Owner

I'm merging some pending changes and solving some issues, I suppose we can increment the versión number by the end of the week.

ArtemKhoda added a commit to ArtemKhoda/angular-leaflet-directive that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants