-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep watching geojson causes performance issues and circular reference errors #595
Comments
Yes @facultymatt, you're totally right. I'm going to change the deep $watch by the $watchCollection shallow watcher. Thanks for reporting. |
…r performance, as stated by @facultymatt here: #595
Thanks so much! Any word on a release date for this change? On Tuesday, January 13, 2015, David Rubert notifications@github.com wrote:
Matt Miller Web Master Superpedestrian Inc. This message is intended only for the addressee named above. If you are |
I'm merging some pending changes and solving some issues, I suppose we can increment the versión number by the end of the week. |
…r performance, as stated by @facultymatt here: tombatossals/angular-leaflet-directive#595
Currently the geojson preforms a deep watch, as you can see here by the true value.
This causes performance issues with large complex objects.
It causes maximum stack errors on object that have circular references.
Is it possible to remove the deep watch, and still get the desired behavior?
The text was updated successfully, but these errors were encountered: