fix(geojson): Shallow watch of the geojson object to accomplish bette…

…r performance, as stated by @facultymatt here: #595
tombatossals · Jan 13, 2015 · c893a1a · c893a1a
1 parent b4e803b
commit c893a1a
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/src/directives/geojson.js b/src/directives/geojson.js
@@ -12,8 +12,7 @@ angular.module("leaflet-directive").directive('geojson', function ($log, $rootSc
                 leafletGeoJSON = {};
 
             controller.getMap().then(function(map) {
-                leafletScope.$watch("geojson", function(geojson) {
-
+                leafletScope.$watchCollection("geojson", function(geojson) {
                     if (isDefined(leafletGeoJSON) && map.hasLayer(leafletGeoJSON)) {
                         map.removeLayer(leafletGeoJSON);
                     }
@@ -25,7 +24,7 @@ angular.module("leaflet-directive").directive('geojson', function ($log, $rootSc
                     var resetStyleOnMouseout = geojson.resetStyleOnMouseout;
                     var onEachFeature;
 
-                    if (geojson.onEachFeature) {
+                    if (angular.isFunction(geojson.onEachFeature)) {
                         onEachFeature = geojson.onEachFeature;
                     } else {
                         onEachFeature = function(feature, layer) {
@@ -56,18 +55,20 @@ angular.module("leaflet-directive").directive('geojson', function ($log, $rootSc
                         };
                     }
 
-                    geojson.options = {
-                        style: geojson.style,
-                        filter: geojson.filter,
-                        onEachFeature: onEachFeature,
-                        pointToLayer: geojson.pointToLayer
-                    };
+                    if (!isDefined(geojson.options)) {
+                        geojson.options = {
+                            style: geojson.style,
+                            filter: geojson.filter,
+                            onEachFeature: onEachFeature,
+                            pointToLayer: geojson.pointToLayer
+                        };
+                    }
 
                     leafletGeoJSON = L.geoJson(geojson.data, geojson.options);
                     leafletData.setGeoJSON(leafletGeoJSON, attrs.id);
                     leafletGeoJSON.addTo(map);
 
-                }, true);
+                });
             });
         }
     };