docs: update docs for from_std functions
#3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Oct 24, 2020
Comment on lines
167
to
168
| /// This can be used in conjunction with net2's `UdpBuilder` interface to | ||
| /// configure a socket before it's handed off, such as setting options like |
There was a problem hiding this comment.
I don't think it has to be part of this PR, but net2 is deprecated and this should also be updated as well.
There was a problem hiding this comment.
Opened #3034 to track this.
taiki-e
approved these changes
Oct 24, 2020
mxinden
added a commit
to libp2p/rust-libp2p
that referenced
this pull request
Nov 2, 2020
mxinden
added a commit
to libp2p/rust-libp2p
that referenced
this pull request
Nov 2, 2020
mxinden
added a commit
to libp2p/rust-libp2p
that referenced
this pull request
Nov 3, 2020
* Update tokio requirement from 0.2 to 0.3 Updates the requirements on [tokio](https://github.com/tokio-rs/tokio) to permit the latest version. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-0.2.0...tokio-0.3.0) Signed-off-by: dependabot[bot] <support@github.com> * protocols/mdns: Ensure to set non_blocking on tokio udp socket * transports/tcp: Ensure to set non_blocking on tokio tcp socket See tokio-rs/tokio#3016 for details. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Inden <mail@max-inden.de>
santos227
pushed a commit
to santos227/rustlib
that referenced
this pull request
Jun 20, 2022
* Update tokio requirement from 0.2 to 0.3 Updates the requirements on [tokio](https://github.com/tokio-rs/tokio) to permit the latest version. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-0.2.0...tokio-0.3.0) Signed-off-by: dependabot[bot] <support@github.com> * protocols/mdns: Ensure to set non_blocking on tokio udp socket * transports/tcp: Ensure to set non_blocking on tokio tcp socket See tokio-rs/tokio#3016 for details. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Inden <mail@max-inden.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3007
Motivation
Some of the docs for
from_stdmethods are outdated.Solution
Update and unify docs.