Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mentions of net2 #3034

Closed
Darksonn opened this issue Oct 24, 2020 · 1 comment · Fixed by #3056
Closed

Change mentions of net2 #3034

Darksonn opened this issue Oct 24, 2020 · 1 comment · Fixed by #3056
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-net Module: tokio/net T-docs Topic: documentation

Comments

@Darksonn
Copy link
Contributor

The net2 crate is deprecated, so our documentation should recommend another crate. One such mention can be found here:

/// This can be used in conjunction with net2's `UdpBuilder` interface to
/// configure a socket before it's handed off, such as setting options like
/// `reuse_address` or binding to multiple addresses.

I have not checked whether there are other mentions than the one above.

@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Topic: documentation E-easy Call for participation: Experience needed to fix: Easy / not much C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 24, 2020
@zaharidichev
Copy link
Contributor

I will take that

zaharidichev added a commit to zaharidichev/tokio that referenced this issue Oct 27, 2020
Fixes: tokio-rs#3034

Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
@Darksonn Darksonn removed E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-net Module: tokio/net T-docs Topic: documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants