Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons layout does not fit #9

Closed
jirihelmich opened this issue May 10, 2016 · 2 comments
Closed

Buttons layout does not fit #9

jirihelmich opened this issue May 10, 2016 · 2 comments

Comments

@jirihelmich
Copy link

image

@tobice
Copy link
Owner

tobice commented May 10, 2016

Fixed only partially by redesigning the toolbar. The problem is still there but less apparent.

The problem is that each button is a separated component with decoupled functionality and state (wrapped by the redux higher order connect() component). The UI library is then unable to align the buttons properly. It's a trade-off between nicely structured code and perfect visual output.

@tobice
Copy link
Owner

tobice commented May 13, 2016

Okay, there is an actual bug in the Material UI library. The RaisedButton when used as a standard link (<a href="">...</a>) is shifted a bit down which is the case of the publish button on the screen shot. The bug is fixed in the recent versions of Material UI library which however introduces breaking changes. As the update would be probably complicated and it's not a real priority, I implemented a simple work around.

Nevertheless, the reasons mentioned in the post above are still valid. The visual output will most likely never be perfect (for example, buttons in such a toolbar should seemingly merge into one but they are clearly separated by overlapping shadows that should not be there).

@tobice tobice closed this as completed in 24dd853 May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants