Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons dont align when one is a link button and the other is regular #2801

Closed
sbberic opened this issue Jan 5, 2016 · 6 comments
Closed
Labels
bug 🐛 Something doesn't work

Comments

@sbberic
Copy link

sbberic commented Jan 5, 2016

When I put:

<RaisedButton label="Hello"/>
<RaisedButton label="World" linkButton={true}/>

screen shot 2016-01-05 at 3 30 53 pm

the none linked button has an extra space above it. but when I have:

<RaisedButton label="Hello" linkButton={true}/>
<RaisedButton label="World" linkButton={true}/>

screen shot 2016-01-05 at 3 32 35 pm

this seems to be caused by display: inline-block on the anchor element:
with anchor display:inline-block
screen shot 2016-01-05 at 3 34 23 pm
without:
screen shot 2016-01-05 at 3 34 38 pm

@shotolab
Copy link

Applying linkButton to a raised button with a width set in style also changes the button label to be left aligned. (0.14.4)

@oliviertassinari
Copy link
Member

That should be fixed on the master branch. Can someone confirm?

@mbrookes
Copy link
Member

The vertical alignment is fixed, but @shotolab is correct about the left alignment:
image

@shotolab, I'm going to close this one, but can you please search for an existing issue for the left alignment propblem, and open a new if there isn't one already? Feel free to submit a PR - it should be a relatively easy one to pin down (famous last words! 😄 )

@shotolab
Copy link

Button left alignment issue #3456

@mbrookes
Copy link
Member

👍

@tobice
Copy link

tobice commented Jun 2, 2016

Do I understand this correctly that this bug should be fixed now? I've just updated to 0.15 and the link buttons are still not aligned. The symptoms are the same, applying display: inline !important on the anchor element fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

5 participants