INT-2974: Support OnPush change detection #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchC1999
approved these changes
Jan 18, 2024
6088844 to
f72a3a9
Compare
TheSpyder
approved these changes
Apr 4, 2024
TheSpyder
reviewed
Apr 4, 2024
Co-authored-by: Andrew Herron <thespyder@programmer.net>
danoaky-tiny
added a commit
that referenced
this pull request
Apr 8, 2024
* INT-2974: Now uses OnPush change detection * INT-2974: Added a story to show support for OnPush change detection form/parent element * INT-2974: Added changelog entry * INT-2974: Update CHANGELOG.md Co-authored-by: Andrew Herron <thespyder@programmer.net> --------- Co-authored-by: Andrew Herron <thespyder@programmer.net>
danoaky-tiny
added a commit
that referenced
this pull request
Apr 8, 2024
* INT-2974: Now uses OnPush change detection * INT-2974: Added a story to show support for OnPush change detection form/parent element * INT-2974: Added changelog entry * INT-2974: Update CHANGELOG.md Co-authored-by: Andrew Herron <thespyder@programmer.net> --------- Co-authored-by: Andrew Herron <thespyder@programmer.net>
danoaky-tiny
added a commit
that referenced
this pull request
Apr 24, 2024
* INT-2974: Now uses OnPush change detection * INT-2974: Added a story to show support for OnPush change detection form/parent element * INT-2974: Added changelog entry * INT-2974: Update CHANGELOG.md Co-authored-by: Andrew Herron <thespyder@programmer.net> --------- Co-authored-by: Andrew Herron <thespyder@programmer.net>
danoaky-tiny
added a commit
that referenced
this pull request
Apr 24, 2024
* INT-3274: Updated bug_report template * INT-3274: Updated deps to Angular 17 and fixed tests * INT-3274: Added new storybook dependencies * INT-3274: Added angular.json for storybook compat * INT-3274: Added .browserslistrc * INT-3274: Migrated stories to new v7 storybook format * INT-3274: Added `preinstall` back * INT-3274: Eslint fix * INT-3274: Moved target change to storybook specific tsconfig, and put back comment * INT-3274: Reverted unnecessary format * INT-3274: Edited comment * INT-3274: Trimmed out unnecessary builds and props from `angular.json` * INT-3274: Add gh-pages for storybook deployment * INT-3274: Patch angular update * INT-3274: Removed old tslint ignore * INT-3274: Fix rxjs deprecated usage * INT-3274: Recreated yarn.lock * INT:3274: Use node v20 for Jenkins CI * INT-3274: Disable storybook telemetry * INT-3274: Removed react dev dependencies * INT-3274: Added react and react-dom back as they're peer dependencies of storybook addons * INT-3274: Fixed storybook warnings about included unused imports * INT-3274: Upgrade dependencies * INT-3274: Added changelog entries * INT-3274: Updated issue template code sandbox * INT-3274: Remove zone.js-11 dependency * INT-3274: Use waluigi v7 * INT-3274: Bumb minor version * INT-3274: Added publish step back again * INT-3274: Add testContainer arg * INT-3274: Add "yarn build" step * INT-2974: Support OnPush change detection (#368) * INT-2974: Now uses OnPush change detection * INT-2974: Added a story to show support for OnPush change detection form/parent element * INT-2974: Added changelog entry * INT-3274: Bumb patch version As feature/INT-2974 used 7.1.0-rc tag already * INT-3274: rc.2 * INT-3274: Change `6-dev` loading test to use `6` instead * INT-3274: Refactored to `isObserved` fn * INT-3274: Simplified the ScriptLoader to use plain rxjs --------- Co-authored-by: Andrew Herron <thespyder@programmer.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: INT-2974
Description of changes:
As described in #311, when a parent component was using OnPush change detection, changes made in the editor component weren't picked up.
This is fixed by changing the editor's change detection strategy to use OnPush itself, and marking when changes need to be checked manually. Changes are marked to be checked on the editor's blur event and on any of the
modelEvents. This covers both for checking when "touched" and when made "dirty".I've also added a Storybook component to show this functionality.
Note:
This PR depends on changes in #367, so merge that first.Moved the base to feature-INT-3274. So this is being merged first now.